Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LEGACY] Digital Bitbox Hardware Wallet Support #217

Closed
wbobeirne opened this issue Sep 20, 2017 · 7 comments · May be fixed by protokiller/MyCrypto#38
Closed

[LEGACY] Digital Bitbox Hardware Wallet Support #217

wbobeirne opened this issue Sep 20, 2017 · 7 comments · May be fixed by protokiller/MyCrypto#38
Assignees
Labels
help wanted Issues or features that are good starter tasks that we would love the communities help with. type: feature Items that are larger in scope and are classified as a new feature (as opposed to an enhancement)

Comments

@wbobeirne
Copy link
Contributor

Re-implement Digital Bitbox decrypting and send support from v3

@wbobeirne wbobeirne added type: feature Items that are larger in scope and are classified as a new feature (as opposed to an enhancement) 2_wallet decrypt labels Sep 20, 2017
@wbobeirne wbobeirne self-assigned this Sep 20, 2017
@wbobeirne wbobeirne mentioned this issue Sep 20, 2017
15 tasks
@wbobeirne
Copy link
Contributor Author

wbobeirne commented Sep 20, 2017

I've hit a wall on this one, I'm getting the very opaque client error code 4, DEVICE_INELIGIBLE (See here) It seems v3 is also facing this problem, and my implementation is identical, so I'm not sure how this was ever working. @douglasbakkum if you are available to talk this out, you can find me on the MEW slack or shoot me an email on my profile.

@wbobeirne wbobeirne added the help wanted Issues or features that are good starter tasks that we would love the communities help with. label Sep 20, 2017
@douglasbakkum
Copy link

@wbobeirne Will send an email.

Note that the Digital Bitbox will only communicate with a website that has https://www.myetherwallet.com as a base URL (or https://digitalbitbox.com) (https://www.myetherwallet.com/test or like that will work) - this prevents phishing attacks. Maybe you are testing using a different server?

@Zwilla
Copy link

Zwilla commented Oct 5, 2017

Does this mean, that everyone who want to run an absolute cold storage can’t use a digital bitbox?
If yes = stupid!

Because if you can not trust a bitbox itself it is worthless!!! Take a look at ledger wallet, this is an absolut 0-Trust wallet!

@wbobeirne
Copy link
Contributor Author

In our email correspondence, I requested that localhost also be whitelisted for running MEW offline.

@wbobeirne
Copy link
Contributor Author

The Digital Bitbox team just shot me this reference implementation of it running in Electron by directly interfacing with HID: https://github.com/digitalbitbox/ElectronDemo. This means that Digital Bitbox support will probably be limited to Electron until they update the firmware to whitelist mycrypto.com, but this will allow it to work offline.

@tapir
Copy link

tapir commented Aug 10, 2018

Digital bitbox supports mycrypto since firmware 3.0.0. It's been quite a while since it's released. This is a feature originally existed in MEW. Why isn't it enabled yet?

@SharonManrique
Copy link
Contributor

Added to Asana

@ConnorBryan ConnorBryan changed the title Digital Bitbox Hardware Wallet Support [LEGACY] Digital Bitbox Hardware Wallet Support Aug 28, 2018
@tayvano tayvano closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues or features that are good starter tasks that we would love the communities help with. type: feature Items that are larger in scope and are classified as a new feature (as opposed to an enhancement)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants