Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little UI / CSS Issues #270

Closed
3 tasks done
tayvano opened this issue Oct 6, 2017 · 4 comments
Closed
3 tasks done

Little UI / CSS Issues #270

tayvano opened this issue Oct 6, 2017 · 4 comments
Assignees
Milestone

Comments

@tayvano
Copy link
Contributor

tayvano commented Oct 6, 2017

  • 1. After clicking the "verify" button, the active state has the text white, meaning you can't read it:

screen shot 2017-10-06 at 10 19 43 am

  • 2. When you send 2 transactions back to back, it's hard to tell which one is the new one. Perhaps fade out previous one opacity: .8; opacity: .6; ... to differentiate

screen shot 2017-10-06 at 10 24 14 am

  • 3. When using Ledger, you press generate and a spinner shows up (YAY!). If possible, let's add a message that says "Please confirm transaction on your hardware wallet" next to it. Can be super small.

screen shot 2017-11-09 at 10 03 44 pm

@dternyak dternyak added this to the Sprint 1 milestone Oct 10, 2017
@dternyak dternyak removed this from the Sprint 1 milestone Oct 17, 2017
@james-prado
Copy link
Contributor

james-prado commented Oct 18, 2017

I've made a branch here to fix the issue. I've added animations on notifications to make it clear to the user which notification is new and which is old. React-transition-group seems to be one of the better animation libraries to react, it makes animations before dismount very easy, however I've found and issue using it with redux so I've opened an issue for it and am awaiting a response.

A demo of the issue can be found here

This branch also fixes the white text issue.

@james-prado
Copy link
Contributor

Ok, turns out using the notification array index as a key is VERY BAD and messes up react displays data.

@james-prado
Copy link
Contributor

Closed by pr MyEtherWallet/MyEtherWallet#305

@james-prado
Copy link
Contributor

MyEtherWallet/MyEtherWallet#305 only solves 2/3 of the issues, re-opening to fix part 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants