Use babel minifier instead of uglify #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our modules end up with ES6+ code in them as they're meant for a purely node environment. We could pull request and fix every problem, but it's killing our
npm run build
right now. As a quick stopgap for that, I've switched the prod webpack config to use babel-minify / babili now. In addition to handling those cases, I'm also seeing some huge file size improvement:Old
Time: 32712ms
New
Time: 122573ms
Unfortunately, as you can see, it's noticeably slower. But we only build once per release, so I'd say it's worth it.