No Javascript / Old Browser Blockers #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally MyEtherWallet/MyEtherWallet#274
What This Does
Closes out #79:
The copy for either of these is totally up or editing, I just threw something together. Please advise @tayvano.
How to Test
npm run build
http-server
or something to serve up thedist/
folderJanky Implementations
Because a few of the third party modules make it into our vendor bundle with a
const
here and alet
there, I decided that to keep this as fail-proof as possible, I would do the bad browser check outside of the main code bundle. So you'll find it, along with all of the markup for these, at the bottom ofindex.html
. This wasn't ideal, but after having the common or vendor bundles fail for a myriad of reasons, felt like a real gordian knot chop.Also, because they're not served up via React, I couldn't make a nice common component for these kinds of page blockers. So instead I made a sass mixin,
@mixin cover-message
which applies the styles, but allows for customization and overrides.Requires #273 to work due to needing to be tested with the
npm run build
version of this.Screenshots