-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate transaction notifications & fix styles #305
Changes from all commits
9ea3884
6f2bd19
60db6b4
2aa4942
88f6bd1
b9f5244
099cd0e
46af5cf
244b4c0
141ebec
d991711
038415d
dfe3afe
fb39318
d189b49
ece40e8
e8094af
e5fecd6
9d3ab19
d28da44
66b473e
dbb5644
fff9663
fbfbc6c
2c27004
176e5d5
cfee8d9
02f6fd4
7b7dfff
e8bd2bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -307,14 +307,14 @@ export class SendTransaction extends React.Component<Props, State> { | |
onChange={readOnly ? void 0 : this.onGasChange} | ||
/> | ||
{(offline || forceOffline) && ( | ||
<div> | ||
<NonceField | ||
value={nonce} | ||
onChange={this.onNonceChange} | ||
placeholder={'0'} | ||
/> | ||
</div> | ||
)} | ||
<div> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see no changes here except for formatting. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just added a new commit to clean up the rest of the formatting noise, the one thing I couldn't change was the indentation you highlighted, it gets formatted that way by the |
||
<NonceField | ||
value={nonce} | ||
onChange={this.onNonceChange} | ||
placeholder={'0'} | ||
/> | ||
</div> | ||
)} | ||
{unit === 'ether' && ( | ||
<DataField | ||
value={data} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,7 +88,6 @@ | |
&:hover, | ||
&:focus, | ||
&.focus { | ||
color: white; | ||
text-decoration: none; | ||
opacity: 1; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the latest
react-transition-group
in a while, but I'm pretty sure having both of these transition components is overkill. I think all you want isCSSTransition
. Their example of CSSTransition doesn't useTransitionGroup
at all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For animating individual elements, like in the CSSTransition example,
TransitionGroup
isn't necessary. But, if you want to manage multipleCSSTransition
orTransition
elements, TransitionGroup is required.