This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Feature/gui connection update #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single websocket but don't send data from clients to other clients.
This allows simple websocket clients to connect as well.
devs-mycroft
added
the
CLA: Yes
|
Works for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify the gui websocket code. This uses a single port instead of generating a server for each connection. The GUI's are separated through the tornado websocket handlers not passing messages to each other and only to/from the Mycroft bus.
Should resolve #2525.
How to test
Make sure the mycroft-gui application can connect and run.
Contributor license agreement signed?
CLA [ Yes ]