This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Allow building Mycroft with loose requirements #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
|
Thanks for this! Note that the same should happen for |
chrisveilleux
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow pip install to use "loose" requirements (>= instead of ==) by setting the
MYCROFT_LOOSE_REQUIREMENTSenvironment variable.The intention of this is to allow installs with desktop packages instead of using pip to be smoother while allowing the git installation to still guarantee the expected module versions. (Discussed in #2517).
This will not be guaranteed to work, but allows packagers for distributions to install their own versions of the Mycroft dependencies through their packaging manager.
Example
MYCROFT_LOOSE_REQUIREMENTS=true pip install .How to test
Create a test virtual environment, activate it and run
MYCROFT_LOOSE_REQUIREMENTS=true pip install .Make sure the installed versions are of the packages are the latest (for example requests should be the latest version), (depending on the arch and system this MAY FAIL to setup due to fann2 1.1.2 which has a broken install on some systems. If this occurs install the 1.0.7 version separately.Contributor license agreement signed?
CLA [ Yes ] (Whether you have signed a CLA - Contributor Licensing Agreement