Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Allow override for animations in platform skills #2657

Merged
merged 9 commits into from
Aug 19, 2020

Conversation

AIIX
Copy link
Collaborator

@AIIX AIIX commented Aug 12, 2020

Description

Allows setting an override for animations like talking, thinking, listening in platform skills like skill-mark-2 for interactive GUI pages, This helps skills developers decide weather they want the general animations disabled for a page, for example when expecting response in a speech dialog without moving focus away from the content displayed on the page.

The option by default is set to always show all animations.

How to test

self.gui.show_page("example.qml", override_animations=True)

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@pep8speaks
Copy link

pep8speaks commented Aug 12, 2020

Hello @AIIX! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-12 16:34:01 UTC

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 12, 2020
@AIIX AIIX requested a review from forslund August 12, 2020 16:15
@JarbasAl
Copy link
Contributor

👍 i like this

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

Sounds like a good idea.

I think the original idea was that the get_response() start of listening shouldn't generate a listening -> thinking -> speaking cycle if a skill page is shown so this should maybe be default behaviour.

I'm away from my gui setup at the moment but I will test this together with your Mark-2 PR on Monday and see it all in action.

@krisgesling krisgesling self-requested a review August 19, 2020 06:53
@krisgesling krisgesling merged commit fac4744 into MycroftAI:dev Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants