This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow override for animations in platform skills #2657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest
Update to latest
Update to latest
Update to latest
update to latest
update to latest
Update to latest commit
devops-mycroft
added
the
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
label
Aug 12, 2020
👍 i like this |
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
Voight Kampff Integration Test Succeeded (Results) |
Sounds like a good idea. I think the original idea was that the get_response() start of listening shouldn't generate a listening -> thinking -> speaking cycle if a skill page is shown so this should maybe be default behaviour. I'm away from my gui setup at the moment but I will test this together with your Mark-2 PR on Monday and see it all in action. |
krisgesling
approved these changes
Aug 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows setting an override for animations like talking, thinking, listening in platform skills like skill-mark-2 for interactive GUI pages, This helps skills developers decide weather they want the general animations disabled for a page, for example when expecting response in a speech dialog without moving focus away from the content displayed on the page.
The option by default is set to always show all animations.
How to test
self.gui.show_page("example.qml", override_animations=True)
Contributor license agreement signed?
CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement