This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Voight Kampff given timeout #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new given sets the timeout of the steps in a scenario. The timeout is reset after each scenario.
This allows wait for dialog to respect the timeout set for the current scenario.
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results) |
chrisveilleux
approved these changes
Sep 8, 2020
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following some discussions with @krisgesling.
This adds a couple of given statements for setting the timeout for each of the steps in the scenario. After scenario completion the step timeout is returned to to original 10 seconds. Hopefully we won't be needed to go above 10 seconds in too many cases, but the option can be good to have for computation heavy tasks or tasks relying on an external data source.
How to test
Create a simple test for a skill and add a 25 second delay (to not trigger within the retry) before the speak command. ensure that this test fails then add a
And a 30 second timeoutafter the given step.Contributor license agreement signed?
CLA [ Yes ]