Feature/mozilla tts #2713

domcross · 2020-10-01T18:18:34Z

Description

Implement TTS module for Mozilla-TTS server

How to test

Fire up Mozilla-TTS server, set mycroft.conf: tts.module "mozilla" and configure tts.mozilla.url, mycroft-speak "My name is Mycroft and I am funky"

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

When mycroft_skill.find_resource fails to load a resource for self.lang fall back to lang 'en-us' as most skills/resources are available in english by default. ==== Fixed Issues ==== MycroftAI#2120

update to lastest dev

update dev

another update

update

update to latest dev

update dev

Implement TTS module that works with Mozilla-TTS server. ==== Environment Notes ==== Requires a Mozilla-TTS server running preferably in your local network.

fix missing import and codestyle

pep8speaks · 2020-10-01T18:35:34Z

Hello @domcross! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-06 09:45:18 UTC

devops-mycroft · 2020-10-01T18:54:34Z

Voight Kampff Integration Test Succeeded (Results)

el-tocino · 2020-10-01T18:55:21Z

The dev server moz tts includes can be accessed similarly to mimic2/tacotron, but no visemes are returned. A slightly more generic tool that connects to a url and expects a wav file in return might be ideal, and indicate that moz tts works with this option?

el-tocino · 2020-10-01T18:58:20Z

mycroft/tts/mozilla_tts.py

+
+    def get_tts(self, sentence, wav_file):
+        wav_name = hashlib.sha1(sentence.encode('utf-8')).hexdigest() + ".wav"
+        wav_file = "/tmp/" + wav_name


there's typically a /tmp/mycroft/ folder that might be better used for this. (in fact there's a /tmp/mycroft/cache/tts/ folder)

I think you should be able to use wav_file without modification that should contain the complete path el-tocino mentions. If this is changed the use of local caching won't work.

fix codestyle

devops-mycroft · 2020-10-01T19:30:23Z

Voight Kampff Integration Test Succeeded (Results)

forslund · 2020-10-01T19:32:03Z

Very cool! Are there any good instructions for setting up mozilla TTS server outthere?

domcross · 2020-10-01T19:54:20Z

Very cool! Are there any good instructions for setting up mozilla TTS server outthere?

When you have a pre-trained model you can run server.py from TTS\server which is based on Flask. There are also instructions for Nginx and how to build a server package with the model embedded.

devops-mycroft · 2020-10-01T20:17:59Z

Voight Kampff Integration Test Succeeded (Results)

JarbasAl · 2020-10-01T20:32:36Z

there is also https://github.com/synesthesiam/docker-mozillatts

using the pip .whl for the pre trained model here did not work out of the box for me, i needed to update numpy and downgrade numba for it to work

krisgesling

Nice one! You beat me to it :)

We are going to be extracting all the TTS and STT modules out to plugins, but given the work happening on voices right now I think it makes sense to merge this in.

Outside the scope of this PR, but inspired by it - I'm wondering if we should extract out the phrase chunking functions that are currently in the Mimic2 module so that any TTS module can make use of them?

krisgesling · 2020-10-01T23:57:24Z

mycroft/configuration/mycroft.conf

+    },
+    "mozilla": {
+      "lang": "de",
+      "url": "http://10.0.0.1:5002/api/tts?text="


Wonder if we should default to a 0.0.0.0 IP?

krisgesling · 2020-10-01T23:58:31Z

mycroft/tts/mozilla_tts.py

+from urllib import parse
+from .mimic_tts import VISIMES
+import math
+import base64
+import os
+import re
+import json


Can probably clean some of these up? Presuming they've just been copied across from the Mimic2 module?

domcross · 2020-10-02T08:13:27Z

I'm wondering if we should extract out the phrase chunking functions that are currently in the Mimic2 module so that any TTS module can make use of them?

I have seen these functions and left them out intentionally as Mozilla-TTS server implements phrase chunking functions itself.

fix imports and example config

devops-mycroft · 2020-10-02T12:53:39Z

Voight Kampff Integration Test Succeeded (Results)

Cache handling

devops-mycroft · 2020-10-02T20:26:38Z

Voight Kampff Integration Test Succeeded (Results)

forslund · 2020-10-03T16:38:04Z

Finally got the TTS setup, it's working very well!

I could minimize the get_tts method to

   def get_tts(self, sentence, wav_file):                                      
        req_route = self.url + sentence                                         
        response = requests.get(req_route)                                      
        with open(wav_file, 'wb') as f:                                         
            f.write(response.content)                                           
        return (wav_file, None)  # No phonemes

This lets mycroft take care of all caching instead of duplicating the check here.

Another way to make the code cleaner could be to use the params argument in requests.get

setting the url in config to http://0.0.0.0:5002/api/tts

then doing the request call using requests.get(self.url, params={'text': sentence})

This would automatically escape anything in sentence? that could mess up the url.

remove custom cache code improve url handling

devops-mycroft · 2020-10-05T21:16:52Z

Voight Kampff Integration Test Succeeded (Results)

forslund · 2020-10-06T04:36:16Z

mycroft/tts/mozilla_tts.py

+
+from .tts import TTS, TTSValidator
+from mycroft.configuration import Configuration
+from mycroft.util.log import LOG


Seems like now os, hashlib and mycroft.util.log isn't used. Apart from those tiny things it looks great!

Clean up imports

devops-mycroft · 2020-10-06T10:21:48Z

Voight Kampff Integration Test Succeeded (Results)

domcross · 2020-10-06T12:46:43Z

in case this PR is merged adding the "hacktoberfest-accepted" label to it would be a cool thing ;-)

forslund

Works excellent now! Can without issue say "Sharky & George"

JarbasAl

just noticed i made an "invisible" review, @ChanceNCounter pointed out comments dont appear until i submit the review....

doesnt matter now that it is merged, i opened a new PR with the changes i requested. most changes were addressed either way.

I wonder how many times i thought i reviewed something, but not really....

JarbasAl · 2020-10-01T20:56:25Z

mycroft/configuration/mycroft.conf

@@ -306,6 +306,10 @@
    "espeak": {
      "lang": "english-us",
      "voice": "m1"
+    },
+    "mozilla": {
+      "lang": "de",


lang is not used anywhere

JarbasAl · 2020-10-01T20:56:43Z

mycroft/configuration/mycroft.conf

+    },
+    "mozilla": {
+      "lang": "de",
+      "url": "http://10.0.0.1:5002/api/tts?text="


this should be changed to http://10.0.0.1:5002/api/tts see comment bellow

the example should probably also use localhost, I'm surprised that it's near real time in my laptop

JarbasAl · 2020-10-01T20:57:24Z

mycroft/tts/mozilla_tts.py

+            LOG.info('local response wav found.')
+        else:
+            req_route = self.url + sentence
+            response = requests.get(req_route)


text can be passed like this instead`(see comment above about url)

response = requests.get(self.url, params={"text": sentence})

JarbasAl · 2020-10-01T21:04:21Z

mycroft/tts/mozilla_tts.py

+        pass
+
+    def validate_connection(self):
+        # TODO


in here you could do something like

def validate_connection(self): url = self.tts.config['url'] response = requests.get(url) if not response.status_code == 200: raise ConnectionRefusedError

krisgesling · 2020-10-14T21:46:03Z

Instructions have been added to the docs:
https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/customizations/tts-engine#mozilla-tts

domcross and others added 11 commits November 22, 2019 20:11

Fallback to 'en-us' when resource fails

79f00e3

When mycroft_skill.find_resource fails to load a resource for self.lang fall back to lang 'en-us' as most skills/resources are available in english by default. ==== Fixed Issues ==== MycroftAI#2120

Update mycroft_skill.py

bfd0877

Merge pull request #1 from MycroftAI/dev

f98eb66

update to lastest dev

Merge pull request #2 from MycroftAI/dev

d20cd4d

update dev

Merge pull request #3 from MycroftAI/dev

d42dab0

another update

Merge pull request #4 from MycroftAI/dev

a4328ae

update

Merge pull request #5 from MycroftAI/dev

6bf8f4d

update

Merge pull request #6 from MycroftAI/dev

73908fa

update to latest dev

Merge pull request #7 from MycroftAI/dev

ff2a977

update to latest dev

Merge pull request #8 from MycroftAI/dev

b4a0c51

update dev

MozillaTTS

5be3b54

Implement TTS module that works with Mozilla-TTS server. ==== Environment Notes ==== Requires a Mozilla-TTS server running preferably in your local network.

devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 1, 2020

Mozilla TTS

104c57a

fix missing import and codestyle

el-tocino reviewed Oct 1, 2020

View reviewed changes

Mozilla TTS

65e30ba

fix codestyle

krisgesling reviewed Oct 2, 2020

View reviewed changes

krisgesling added Status: Change requested Type: Enhancement - roadmapped Implementation of a feature that is a priority on the roadmap. labels Oct 2, 2020

Mozilla TTS

d0fb378

fix imports and example config

Mozilla TTS

12ec5cb

Cache handling

Mozilla TTS

99f534c

remove custom cache code improve url handling

forslund reviewed Oct 6, 2020

View reviewed changes

Mozilla TTS

10ded43

Clean up imports

krisgesling added the hacktoberfest-accepted label Oct 6, 2020

forslund approved these changes Oct 6, 2020

View reviewed changes

krisgesling removed the Status: Change requested label Oct 7, 2020

krisgesling merged commit 6e058e4 into MycroftAI:dev Oct 7, 2020

JarbasAl mentioned this pull request Oct 10, 2020

mozilla TTS validation #2719

Closed

JarbasAl reviewed Oct 10, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/mozilla tts #2713

Feature/mozilla tts #2713

domcross commented Oct 1, 2020

pep8speaks commented Oct 1, 2020 •

edited

Loading

devops-mycroft commented Oct 1, 2020

el-tocino commented Oct 1, 2020 •

edited

Loading

el-tocino Oct 1, 2020 •

edited

Loading

forslund Oct 1, 2020

devops-mycroft commented Oct 1, 2020

forslund commented Oct 1, 2020

domcross commented Oct 1, 2020 •

edited

Loading

devops-mycroft commented Oct 1, 2020

JarbasAl commented Oct 1, 2020 •

edited

Loading

krisgesling left a comment

krisgesling Oct 1, 2020

krisgesling Oct 1, 2020

domcross commented Oct 2, 2020

devops-mycroft commented Oct 2, 2020

devops-mycroft commented Oct 2, 2020

forslund commented Oct 3, 2020

devops-mycroft commented Oct 5, 2020

forslund Oct 6, 2020

devops-mycroft commented Oct 6, 2020

domcross commented Oct 6, 2020

forslund left a comment

JarbasAl left a comment •

edited

Loading

JarbasAl Oct 1, 2020

JarbasAl Oct 1, 2020

JarbasAl Oct 1, 2020

JarbasAl Oct 1, 2020

JarbasAl Oct 1, 2020

krisgesling commented Oct 14, 2020

Feature/mozilla tts #2713

Feature/mozilla tts #2713

Conversation

domcross commented Oct 1, 2020

Description

How to test

Contributor license agreement signed?

pep8speaks commented Oct 1, 2020 • edited Loading

Comment last updated at 2020-10-06 09:45:18 UTC

devops-mycroft commented Oct 1, 2020

el-tocino commented Oct 1, 2020 • edited Loading

el-tocino Oct 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devops-mycroft commented Oct 1, 2020

forslund commented Oct 1, 2020

domcross commented Oct 1, 2020 • edited Loading

devops-mycroft commented Oct 1, 2020

JarbasAl commented Oct 1, 2020 • edited Loading

krisgesling left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domcross commented Oct 2, 2020

devops-mycroft commented Oct 2, 2020

devops-mycroft commented Oct 2, 2020

forslund commented Oct 3, 2020

devops-mycroft commented Oct 5, 2020

Choose a reason for hiding this comment

devops-mycroft commented Oct 6, 2020

domcross commented Oct 6, 2020

forslund left a comment

Choose a reason for hiding this comment

JarbasAl left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krisgesling commented Oct 14, 2020

pep8speaks commented Oct 1, 2020 •

edited

Loading

el-tocino commented Oct 1, 2020 •

edited

Loading

el-tocino Oct 1, 2020 •

edited

Loading

domcross commented Oct 1, 2020 •

edited

Loading

JarbasAl commented Oct 1, 2020 •

edited

Loading

JarbasAl left a comment •

edited

Loading