Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Fix/add missing skill_id parameter for page interaction and focus events #2732

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

AIIX
Copy link
Collaborator

@AIIX AIIX commented Oct 23, 2020

Description

Adds missing skill_id parameter for page interaction events and page focus events

How to test

gui.page_interaction bus event should have skill_id available in data

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 23, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as nicely as it looks

@krisgesling krisgesling merged commit 6301d19 into MycroftAI:dev Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants