This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Refactor/stop speaking #2821
Merged
Refactor/stop speaking #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filesystem signal has not been used for quite some time and should not be used.
This also updates the relevant testcase
Add logic to ensure the play_* functions are called at least once before checking the call status.
devops-mycroft
added
the
CLA: Yes
krisgesling
approved these changes
Feb 2, 2021
krisgesling
added
the
Status: Accepted
|
Voight Kampff Integration Test Failed (Results). |
forslund
added
the
Type: Refactoring and other improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor update of
stop_speakingremoving the filesystem signal that is no longer used. In addition:Also improved a failing unrelated unittest regarding the simple audioservice backend
How to test
Ensure that the unit tests pass
Contributor license agreement signed?
CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement