Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Issue-2750 - Remove log pollution #2840

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

DiegoAsterio
Copy link
Contributor

Add empty skill directories to a set and remove them whenever they are
no longer empty. Empty skill directories only appear once in the log.

==== Fixed Issues ====
log polution - #2750

Description

fixes #2750

How to test

While running ./start-mycroft.sh debug with log level set to debug (enter :log level DEBUG in the mycroft CLI) create an empty folder inside the skill directory.

Contributor license agreement signed?

  • CLA

Add empty skill directories to a set and remove them whenever they are
no longer empty. Empty skill directories only appear once in the log.

==== Fixed Issues ====
log polution - MycroftAI#2750
Add empty skill directories to a set and remove them whenever they are
no longer empty. Empty skill directories only appear once in the log.

==== Fixed Issues ====
log polution - MycroftAI#2750
@devops-mycroft
Copy link

Hello, @DiegoAsterio, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Feb 15, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Feb 16, 2021
Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up Diego, it works exactly as intended 🙂

Will merge it once we are through the v20.8.1 release.

@krisgesling krisgesling merged commit 17dbaa2 into MycroftAI:dev Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log polution
3 participants