Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the landing page publishing script to avoid registering a service worker #191

Open
1 task done
Tzal3x opened this issue Aug 27, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request landing-page server-portal A label for the server-side portal

Comments

@Tzal3x
Copy link
Collaborator

Tzal3x commented Aug 27, 2024

Description

While publishing the landing page of the server portal to walrus sites, there is a chance that something can go wrong and the service worker registration script may be included to the site resources.

This can cause a bug with a huge impact, because users that use blob.store and have a service worker installed, will not be able to access the landing page of the server portal (plus the sw can interfere with the fetch events of the browser).

For now we are only triple-checking that only the correct resources are published.

To resolve this issue, we should add a safety mechanism that would minimize the aforementioned risk.

Component

portal

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@Tzal3x Tzal3x added enhancement New feature or request server-portal A label for the server-side portal landing-page labels Aug 27, 2024
@Tzal3x Tzal3x changed the title Improve landing page publishing to avoid registering a service worker Improve the landing page publishing script to avoid registering a service worker Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request landing-page server-portal A label for the server-side portal
Projects
None yet
Development

No branches or pull requests

1 participant