This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
Update messages in the exceptions #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For exception e, str(e) is an informal (epurated) description, repr(e) is a technical description
juhtornr
suggested changes
Jan 11, 2018
There was a problem hiding this comment.
The change is good. However I'm wondering should we rename exceptions to *Error(s)?
See e.g. https://stackoverflow.com/a/2906861
|
We discussed with @silverdaz and these exceptions actually are not "Errors" which would require code to die. These exceptions are used for control flow and falls into the category mentioned in that Stackoverflow link: "Not all Exceptions are Errors. SystemExit, KeyboardInterrupt, StopIteration, GeneratorExit are all exceptions and not errors. The word 'Error' in actual errors shows the difference." |
juhtornr
added a commit
that referenced
this pull request
May 30, 2018
Update messages in the exceptions
viklund
pushed a commit
that referenced
this pull request
Nov 22, 2018
Update messages in the exceptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For exception e,
str(e) is an informal (epurated) description,
repr(e) is a technical description