green vegetation fraction scaling of max canopy capacity of rain & snow intercept #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snow interception
|
Let's wait until we have a discussion with Guo-Yue and Liang to see what the best strategy to fix the FVEG scaling issue would be. |
|
Agreed. Note that I don't think this is the best solution to the issue. Also note that the scaling needs to occur here as well: noahmp/src/CanopyHydrologyMod.F90 Line 70 in ba9f679 |
|
yes, agree on both! |
|
This affects the non-refactored code as well, right? |
|
@jesusff yes, there will eventually need to be a second PR to the 4.5 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request method 1 of #91