Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem Doesn't Raise Exceptions #11

Open
Hamdan85 opened this issue Feb 12, 2020 · 1 comment
Open

Gem Doesn't Raise Exceptions #11

Hamdan85 opened this issue Feb 12, 2020 · 1 comment

Comments

@Hamdan85
Copy link

Hey guys... thank you for your work.

Just one observation: trying to fetch anything with invalid/expired api_key returns 401 from api, but you don't raise any exception or success flag... this could lead to major time expending on bug tracking which was exactly what happened here... we're receiving empty collections due unauthorized api response.

@Hamdan85
Copy link
Author

it seems that you guys have a PR already fixing it... hope you analyse and merge:
#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant