Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloatBorder and NormalFloat background for lsp_signature #enhancement #191

Open
alexeygumirov opened this issue Oct 9, 2022 · 3 comments

Comments

@alexeygumirov
Copy link

NeoVIM 0.8

I use ray-x/lsp_signature.nvim plugin for function definitions popups in the floating windows.
Additional parameters are required (as described in the relevant issue here: ray-x/lsp_signature.nvim#193), because without them floating border looks like this:

wrong_border

Borders for this are having default NeoVIM colors because they require following highlight to setup:

  " Neovim (LSP) diagnostics
  if has('nvim')
   ...
    exec 'hi FloatBorder' . s:bg_background
    exec 'hi NormalFloat' . s:bg_background

After this fix borders look correct:
correct border

@alexeygumirov alexeygumirov changed the title FloatBorder and NormalFloat background for lsp_signature FloatBorder and NormalFloat background for lsp_signature #enhancement Oct 9, 2022
@NLKNguyen
Copy link
Owner

Can you make a PR for this, please?

@binarious
Copy link

@NLKNguyen This seems to be a general issue: #195

I could make a PR for this specific issue (18c9cbd), but split panes are broken, too. Are you able to look into this?

@sjshuck
Copy link

sjshuck commented May 24, 2024

Can someone check to see if this is still an issue with Neovim 0.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants