Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObjectPath to AspNetApplicationValueLayoutRenderer #895

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Base: 69% // Head: 69% // Decreases project coverage by -0% ⚠️

Coverage data is based on head (0f2bdba) compared to base (a4ea473).
Patch coverage: 50% of modified lines in pull request are covered.

❗ Current head 0f2bdba differs from pull request most recent head e48089e. Consider uploading reports for the commit e48089e to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #895   +/-   ##
=====================================
- Coverage      69%    69%   -0%     
=====================================
  Files          66     66           
  Lines        1259   1269   +10     
  Branches      323    327    +4     
=====================================
+ Hits          869    870    +1     
- Misses        246    255    +9     
  Partials      144    144           
Impacted Files Coverage Δ
...d/LayoutRenderers/AspNetItemValueLayoutRenderer.cs 81% <ø> (ø)
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs 74% <ø> (ø)
...tRenderers/AspNetApplicationValueLayoutRenderer.cs 61% <50%> (-8%) ⬇️
src/Shared/Internal/StringBuilderExtensions.cs 62% <0%> (-12%) ⬇️
...utRenderers/AspNetRequestDurationLayoutRenderer.cs 58% <0%> (-7%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 897be87 into NLog:master Dec 12, 2022
@snakefoot snakefoot added this to the 5.2.1 milestone Dec 30, 2022
@snakefoot
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants