Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove #boardcomponents, #monsters, and #shop, is no longer available in editor #1498

Closed
antontimmermans opened this issue May 29, 2021 · 5 comments
Assignees
Labels
bug To be tested Dev is done, it should now be tested

Comments

@antontimmermans
Copy link
Collaborator

The editor does not provide the option to remove #monsters, #boardcomponents, and #shop.
image

The description of the use of these variables can be found on: https://github.com/NPBruce/valkyrie/wiki/QuestIniEvent#remove

I have used this in older scenarios and must have had access in the editor to these items (or else I would not have been able to use this). The fact that they are no longer available in 2.5.6 sounds like regression. I cannot say in which version this was still working.

Scenario

-any -

Steps to reproduce the behavior:

  1. Create a new scenario
  2. add any new tile
  3. add any spawn
  4. create a new event, click on 'remove': -->specific tile and spawn show up, but not the #

Expected behavior

When in the editor in an event items are removed, the # (#monsters, #boardcomponents, #shop) must be selectable.
Note: When #monsters is removed, It should NOT trigger any of the removed monsters 'defeated' event.

LogFile

Screenshots

Valkyrie Version

2.5.6

Desktop

  • OS: Windows
  • Browser Chrome
  • Version 10

Additional context

@NicolaZee
Copy link

This is an essential fix for players who do not want to manually edit the scenario text files.

@mayjak mayjak self-assigned this Sep 16, 2021
@antontimmermans
Copy link
Collaborator Author

This issue appears to be the same as #1480

@antontimmermans
Copy link
Collaborator Author

I hope this problem gets solved in the next version of Valkyrie, but until it does this is a workaround:

IMPORTANT: you will need to use a plain text editor (free source code editor like "Atom" or "Notepad++")

1: go to the event where you want to remove #boardcomponents, #monsters, or #shop

2: in that event, Click on to + next to 'Remove Components' and you can select a component from the list to remove. Just select any component (one you can easily recognize, like a tile for example).
image

3: Save your scenario (and check in which *.ini file your event is stored ... by default: events.ini).you can find it at the bottom of the event:
image

4: Open the *.ini file in the sourcecode editor and find your event.
it will look something like this:

[EventEndCleanUp]
display=false
buttons=1
event1=EventEndEpilogue
remove=Tile0

5: now all you need to do is to replace the component on the remove line with any of the special items. It will then look like this for example:

[EventEndCleanUp]
display=false
buttons=1
event1=EventEndEpilogue
remove=#monsters #boardcomponents

6: save the file, and reload your scenario in Valkyrie where it will look like this:
image

ENJOY!

@mayjak
Copy link
Collaborator

mayjak commented Oct 26, 2022

Fixed in coming 2.5.8 release.

@antontimmermans
Copy link
Collaborator Author

Tested in 2.5.8a;
When you click on [+] at Remove Components (see image above).

  • the 'Special' item appears in the selectable options
  • the items #shop #boardcomponents #monsters are selectable.
    the removal of the selected items appears to work as normal during gameplay (not: I did not test #shop)

Side effect:
When you click on [+] at Add Components (see image above), you can also select Special and all items mentioned above. Valkyrie will crash when you reach the event in which you add these 'special' items.

Typically #boardcomponents #monsters should not be added in this way. I can't say for #shop since I never used it, but I assume it is also not the way to add one. SO I think the 'Special' items may only be visible with Remove Components.

@mayjak mayjak closed this as completed in f32ffe6 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug To be tested Dev is done, it should now be tested
Projects
None yet
Development

No branches or pull requests

3 participants