Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 bug fix PRs #374

Merged
merged 35 commits into from
Apr 22, 2024
Merged

4 bug fix PRs #374

merged 35 commits into from
Apr 22, 2024

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Apr 10, 2024 •
edited
Loading

hdunham and others added 16 commits November 16, 2023 11:53
@hdunham
generalize generator_fuel_slope_and_intercept to any fuel
29f4bf7
@hdunham
chp fuel HHV is 1 because fuel measured in kwh
2bc4774
@hdunham
Update CHANGELOG.md
cfde602
@hdunham
Merge branch 'develop' into erp-chp-fuel-bug
1ba1227
@hdunham
avoid indexing using i in 1:length() paradigm
53bea0b
@hdunham
ensure period index is int in tariff processing
ad9ea3f
@hdunham
Update CHANGELOG.md
e0a0982
@hdunham
Merge branch 'develop' into indexing-robustness
223a442
@hdunham
add option soc_min_applies_during_outages
4f728c5
@hdunham
soc_min_applies_during_outages logic
e45969e
@hdunham
fix typo
9ba0eb1
@hdunham
default soc_min_applies_during_outages default to false
dacdc39
@hdunham
Update CHANGELOG.md
9032600
@adfarth
fix export_rate_beyond_net_metering_limit type error
0b33591
@hdunham
Merge branch 'develop' into outage-soc
daf0d5f
@hdunham
Merge pull request #371 from NREL/input-types
22fdbb9 
Input type fix for export_rate_beyond_net_metering_limit
@hdunham hdunham requested a review from rathod-b April 10, 2024 17:02
@Bill-Becker
Copy link
Collaborator

@hdunham added a hot-fix to this PR FYI. Want to change the reviewer to me to expedite?

@hdunham hdunham requested review from Bill-Becker and removed request for rathod-b April 11, 2024 17:37
@Bill-Becker
Copy link
Collaborator

@hdunham I have some very small but important fixes that I'd like to merge and get into the API ASAP. Let me know if you want to merge any more of your open PRs before we merge this.

@hdunham
Copy link
Collaborator Author

hdunham commented Apr 18, 2024

@hdunham I have some very small but important fixes that I'd like to merge and get into the API ASAP. Let me know if you want to merge any more of your open PRs before we merge this.

Just addressed your comments on the fuel slope/intercept PR. I believe that's the last one that could be added, once tests rerun.

@hdunham hdunham changed the title Type conversion for export_rate_beyond_net_metering_limit 4 bug fix PRs Apr 19, 2024
@hdunham hdunham merged commit d7b888a into master Apr 22, 2024
3 of 4 checks passed
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
@hdunham @indu-manogaran
Merge pull request #374 from NREL/develop
1a7391c 
 4 bug fix PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bill-Becker Bill-Becker Bill-Becker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdunham @Bill-Becker @adfarth