Fix PTHP capacity and VAV minimum damper calculation issues #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking up PTHP COPs, give a warning message if the size is nil and default to a 7 kBtu/hr unit for efficiency. Expand the code to give warning messages if the equipment is less than 7 kBtu/hr or above 15 kBtu/hr, and use either 7 kBtu/hr or 15 kBtu/hr to determine equipment efficiency. This change may result in some regression and performance differences for models with PTHP units.
The air_loop_hvac_adjust_minimum_vav_damper_positions method expects that zones have outdoor air and design air flow rate. If the space does not have a DesignSpecificationOutdoorAir object, or it is zero, then the calculation is unnecessary. If either the zone CoolingDesignAirFlowRate or HeatingDesignAirFlowRate are zero, then the zone discharge air fraction (z_d) could have a divide by zero and result in NaN. This crashes the code when trying to calculate the minimum zone ventilation effectiveness (e_vz). Add informative error messages that the zone CoolingDesignAirFlowRate or HeatingDesignAirFlowRate are zero, and default the zone discharge air fraction (z_d) to zero if either the zone minimum discharge airflow rate (v_dz) is zero, or the zone outdoor airflow rate is zero (v_oz).
mdahlhausen
changed the title
eringold
requested changes
Sep 6, 2024
lib/openstudio-standards/standards/Standards.CoilHeatingDXSingleSpeed.rb
Outdated
Show resolved
Hide resolved
eringold
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This issues handles two edge cases, one with PTHPs having undefined capacity, and the other where there is no outdoor or zone design airflow rate when setting the minimum vav damper position.
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)Review Checklist
This will not be exhaustively relevant to every PR.