use global instead of window

[fibo]

Hi,

strnum package is a dependency of fast-xml-parser which is a dependency of @aws-sdk/client-s3.

When I try to bundle with esbuild an AWS lambda that reads/write to S3 I get an error caused by window.parseInt (used in strnum implementation).

Could it be possible to use globalThis.parseInt ?

[amitguptagwl]

Ideally this problem may come only if Number.parseInt is not present and you're not using the library in browser. To handle both, I may try to remove both. Let me try

[amitguptagwl]

Though I have fixed it on my local, can you please check whether your node js version supports parseInt and Number.parseInt?

[fibo]

Yes, for example Node v16 supports both parseInt and Number.parseInt.

If possible, please remove window or use globalThis or whatever you think it is worth to support isomorphic JS.

Thanks