-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fixes so BuyPass Go ACME server can be used #1989
Conversation
If certbot can work out of the box aginst buypass, we should also be able to. please fix it in the code directly, I think it's in the ACME v1 specific blocks. Thaanks |
I think we should be able to remove any "buypass" or "BUYPASS" string from the code. |
Changed the code to fix it directly in v1 code then. Tested this with CloudFlare DNS authorization on a CentOS 7 server, with: |
acme.sh
Outdated
@@ -13,6 +13,8 @@ _SCRIPT_="$0" | |||
|
|||
_SUB_FOLDERS="dnsapi deploy" | |||
|
|||
BUYPASS_CA="https://api.buypass.no/acme/directory" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove it
Apologies if this has been mentioned elsewhere, but I did not find it: Where are certificates being kept if you use the exact same parameters/(sub)domains but reference different server URIs/CAs? |
Yes, if there is an existing cert, no matter from the same CA or a different CA, the user always gets a warning. The user MUST use |
Had to add a few tweaks to be able to use the ACME server for BuyPass GO, as it seems to not quite conform to the ACME v1 specs implemented currently in acme.sh.
Resources:
https://api.buypass.com/acme/directory
https://www.buypass.com/ssl/resources/go-ssl-technical-specification
The tweaks should not affect existing functionality, and I've done some basic testing on CentOS.