Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: switch jwt lib #307

Merged
merged 3 commits into from
Nov 17, 2021
Merged

WIP: switch jwt lib #307

merged 3 commits into from
Nov 17, 2021

Conversation

Nerzal
Copy link
Owner

@Nerzal Nerzal commented Sep 28, 2021

This change introduces a breaking change.
Instead of passing the expected audience into the DecodeToken functions, we can validate the expected audience with a call to VerifyAudience: https://pkg.go.dev/github.com/golang-jwt/jwt#MapClaims.VerifyAudience

Adresses issue #292

When using custom claims, you'd have to implement the audience check for yourself for now.
I'm open for better ideas regarding the audience validation.

@Nerzal Nerzal changed the title Feature/switch jwt lib WIP: switch jwt lib Sep 28, 2021
@msvechla
Copy link
Contributor

In light of the recent CVEs in github.com/dgrijalva/jwt-go I think this breaking change is fine. As long as they are well documented in the Changelog, I don't see an issue with this.

@Nerzal Nerzal merged commit 227e200 into main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants