yParity missing from EIP-2930 and 1559 transactions.

[MicahZoltu]

Describe the bug

nethermind/src/Nethermind/Nethermind.JsonRpc/Data/TransactionForRpc.cs

Line 63 in f317d61

V = transaction.Type == TxType.Legacy ? (UInt256?)signature.V : (UInt256?)signature.RecoveryId;

yParity should be returned for 2930 and 1559 transactions, not v. It would not be unreasonable to continue filling in v for backward compatibility since a version has already been released with that, but transactions should be returning yParity as well.

See ethereum/execution-specs#293 for details.

Additional context
It is unfortunate that no one noticed this discrepancy prior to launch of Berlin and then London, but it is better to fix it now than to continue incorrectly populating only a v when we don't actually have a v.

[kjazgar]

We agree that yParity should be returned in these cases, however we checked that geth returns v as well. So the question is whether changing this would not cause any problems? Do we have consensus between all client teams?

[MicahZoltu]

At the least, yParity should be returned along side v. I can appreciate also returning v for compatibility with Geth, if they put yParity into v incorrectly, but even in that case we should include a yParity field I think.