Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded pivot and set it basing on CL message #4895

Closed
marcindsobczak opened this issue Nov 11, 2022 · 0 comments · Fixed by #5256
Closed

Remove hard-coded pivot and set it basing on CL message #4895

marcindsobczak opened this issue Nov 11, 2022 · 0 comments · Fixed by #5256
Assignees
Labels
difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. performance is good sync ux

Comments

@marcindsobczak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Before we even start syncing, we need to download blocks between pivot and current head. It's not a problem just after releases when hard-coded pivot is close to chain head, but after few days/weeks it significantly slow us down - downloading post-pivot blocks can make our syncing process with 2-3 weeks old pivot even 30-40% longer.

Describe the solution you'd like
We can remove hard-coded pivot (or left it as it is, but overwrite) and set pivot basing on message from CL - e.g. use finalized block from FCU message.

@marcindsobczak marcindsobczak added performance is good difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. sync ux labels Nov 11, 2022
@marcindsobczak marcindsobczak self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. performance is good sync ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant