-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split in WhatsAppUpdate and WhatsAppClient #32
Comments
Hi @soerenetler I like the idea, how are we going to ensure that this update is not going to break code of people who already created it using a version with only |
@Kalebu, |
We don't have automated testing yet but you're welcome to contribute and |
Also regarding the breaking changes problem I think we can create a WhatsAppUpdate as a different class inherited by the WhatsApp class so that it works in both ways, making it easier to maintain without breaking any existing code base. |
I just created a new PR for automated testing. #38 |
Hi,
i think it would make sense to split the
WhatsApp
class into aWhatsAppUpdate
andWhatsAppClient
class. Many of the functions lower in the file likeget_location
don't actually need the Client. This would make the library easier to handle. One could create aWhatsAppUpdate
object from the data and call theget_location
on that Only sending messages would need theWhatsAppClient
object.I would be happy to contribute to the project. Let me know what you think about this proposal.
The text was updated successfully, but these errors were encountered: