Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ca-derivations downstream placeholder does not start with storeDir #12361

Open
2 tasks done
roberth opened this issue Jan 27, 2025 · 0 comments
Open
2 tasks done

ca-derivations downstream placeholder does not start with storeDir #12361

roberth opened this issue Jan 27, 2025 · 0 comments
Labels
bug ca-derivations Derivations with content addressed outputs language The Nix expression language; parser, interpreter, primops, evaluation, etc store Issues and pull requests concerning the Nix store

Comments

@roberth
Copy link
Member

roberth commented Jan 27, 2025

Describe the bug

Do ca-derivations downstream placeholders need to of the format /[a-z0-9]{52}?
The current behavior leads to bugs in code that is not aware of this behavior (e.g. NixOS/nixpkgs#261512), and even when the code is fixed, this placeholder is incomprehensible when it leaks out in e.g. thrown errors in the Nix language.

Steps To Reproduce

Expected behavior

A placeholder contains the storeDir and name, so that relevant info about the placeholder can be understood by code and humans.

If there's a store layer benefit, we could even handle this at the language level, but changing the store layer to work with store path-like placeholders seems like a simpler and more complete solution.

Metadata

Additional context

Checklist


Add 👍 to issues you find important.

@roberth roberth added bug ca-derivations Derivations with content addressed outputs language The Nix expression language; parser, interpreter, primops, evaluation, etc store Issues and pull requests concerning the Nix store labels Jan 27, 2025
@roberth roberth added this to the ca-derivations stabilisation milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ca-derivations Derivations with content addressed outputs language The Nix expression language; parser, interpreter, primops, evaluation, etc store Issues and pull requests concerning the Nix store
Projects
None yet
Development

No branches or pull requests

1 participant