flameshot: autostart doesn't work & bad desktop file

[YizhePKU]

Checklist

• Checked the nixpkgs master branch

• Checked the nixpkgs pull requests

Project name

nix search name: flameshot

current version: 0.10.1
desired version: master (7977cbb), see below for explanation

Notify maintainers

maintainers: @scode

Note for maintainers

Please tag this issue in your PR.

---

Currently, there're two issues that affacts flameshot in NixOS:

1. Autostart doesn't work when the directory ~/.config/autostart doesn't exist (Autostart doesn't work on NixOS flameshot-org/flameshot#1975)
2. Desktop file points to /usr/bin/flameshot instead of just flameshot

I've landed a PR that fixes issue 1. To fix issue 2, flameshot needs to be built with cmake flag -DUSE_LAUNCHER_ABSOLUTE_PATH:BOOL=OFF. This flag is also newly added (not present in v0.10.1).

We could upgrade right now, or wait for another minor release.

[newAM]

I appreciate you looking into this, it was on my TODO list.

Are you going to open a PR for the second issue? I think it makes sense to fix now instead of waiting for the next release.

[YizhePKU]

Well, I can certainly open a PR, but it's probably up to the maintainers to decide whether to upgrade or not? If you can "call the shots" then sure consider it done :)

[newAM]

I do not call the shots 😅

I have seen packages update from a release version to an "unstable" version to fix problems, for example:

• tinycc: 0.9.27 -> unstable-2021-10-09 #141201
• pamixer: 1.4 -> unstable-2021-03-29 #139961

I do not know if there is any criteria for updating to an unstable version, but it seems like a good idea in this case.

[YizhePKU]

Well then, I guess I'll open a PR and ask for someone to review it.