Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of link flags for rust seems significant now #173711

Closed
Fuuzetsu opened this issue May 20, 2022 · 3 comments
Closed

Order of link flags for rust seems significant now #173711

Fuuzetsu opened this issue May 20, 2022 · 3 comments
Labels
0.kind: bug Something is broken 6.topic: rust

Comments

@Fuuzetsu
Copy link
Member

Fuuzetsu commented May 20, 2022

Describe the bug

Rust 1.61 and rust builder in nixpkgs don't play nicely together anymore.

See first point of https://github.com/rust-lang/rust/blob/fe5b13d681f25ee6474be29d748c65adcd91f69e/RELEASES.md#compatibility-notes, linking to rust-lang/rust#93901

Steps To Reproduce

I don't have a small/public repro on hand right now. If someone has one, please contribute. If not, I can try to come up with one on Monday. Might be easy to get one out of rust issue tracker as they seem to be getting flooded with linker tickets today due to the change.

Expected behavior

Programs build and link but instead we get linker errors.

Notify maintainers

(edit by artturin)
@andir @LnL7 @Mic92 @zowoq

Metadata

nixpkgs 55fad6c081850b3e1d93f87a72c14a383a8e1e9d, rest not that relevant? I'm using oxalica's rust-overlay to get Rust 1.61.

@Fuuzetsu Fuuzetsu added the 0.kind: bug Something is broken label May 20, 2022
@Fuuzetsu
Copy link
Member Author

I updated to Rust 1.62 and recent nixpkgs and issue seems to be gone somehow. Maybe by luck or maybe rust-lang/rust#96436 had something to do with it?

@duxovni
Copy link
Contributor

duxovni commented Jul 18, 2022

Was this fixed by #177436 ? That seemed to solve all of my nix rust building issues.

@Fuuzetsu
Copy link
Member Author

@duxovni aha, yes, I think this is exactly it. I was surprised to find that -l flags were missing from the output when trying with recent nixpkgs and Rust 1.62 because their wrong order was the cause of an error to start with. I will close the ticket, thank you for the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: rust
Projects
None yet
Development

No branches or pull requests

3 participants