Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt fix-sweave-exit-code.patch at R #25572

Closed
KaiLemke opened this issue May 7, 2017 · 3 comments
Closed

Corrupt fix-sweave-exit-code.patch at R #25572

KaiLemke opened this issue May 7, 2017 · 3 comments

Comments

@KaiLemke
Copy link

KaiLemke commented May 7, 2017

Issue description

Installing R fails, because fix-sweave-exit-code.patch cannot be applied:

applying patch /nix/store/wyfr6an0xj2iiwa8fkrryyzrrv5wnvnk-fix-sweave-exit-code.patch
patching file src/library/utils/R/Sweave.R
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 452.
Hunk #3 FAILED at 577.
3 out of 3 hunks FAILED -- saving rejects to file src/library/utils/R/Sweave.R.rej
builder for ‘/nix/store/y6n3klamjnqnw2mx6rlia5f7829amqnb-R-3.3.3.drv’ failed with exit code 1

Steps to reproduce

add pkgs.R to configuration.nix
nixos-rebuild test --show-trace

Technical details

  • System: NixOS: 17.03.1098.a162c6c828 (Gorilla), stable, 64 Bit
  • Sandboxing enabled: false
@JayVii
Copy link

JayVii commented May 7, 2017

I can confirm. Have the same issue:

unpacking source archive /nix/store/ahvpik8cyjhgirc6zb14hhhc4l554lvh-R-3.3.3.tar.gz
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0source root is R-3.3.3
  setting SOURCE_DATE_EPOCH to timestamp 1488788159 of file R-3.3.3/src/library/utils/inst/doc/Sweave.pdf
  patching sources
  applying patch /nix/store/qnbw3qijmgcyldy30wf66bxyq5cwasbn-no-usr-local-search-paths.patch
  patching file configure
  Hunk #1 succeeded at 3731 (offset -69 lines).
  applying patch /nix/store/wyfr6an0xj2iiwa8fkrryyzrrv5wnvnk-fix-sweave-exit-code.patch
  patching file src/library/utils/R/Sweave.R
  Hunk #1 FAILED at 1.
  Hunk #2 FAILED at 452.
  Hunk #3 FAILED at 577.
  3 out of 3 hunks FAILED -- saving rejects to file src/library/utils/R/Sweave.R.rej
  builder for ‘/nix/store/y6n3klamjnqnw2mx6rlia5f7829amqnb-R-3.3.3.drv’ failed with exit code 1
  )

EDIT: R-3.4.0 from the unstable branch installs and works fine. so either commit 5e5d16f or d16c38a fixed it.

@pschuprikov
Copy link
Contributor

Comparing master and 17.03 it seems that commit d16c38a is missing from the latter. Presumably, the patch was intended for version 3.4.0. @peti, could you, please, check?

peti added a commit that referenced this issue May 19, 2017
This reverts commit 76296ce. That patch is
intended for R 3.4.0 only. Not sure this commit ever appeared here in this
branch. It looks like *I* committed it??? Must have been confused.

Closes #25572.
@peti
Copy link
Member

peti commented May 19, 2017

Fixed by 05b2da8.

@peti peti closed this as completed May 19, 2017
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
This reverts commit 76296ce. That patch is
intended for R 3.4.0 only. Not sure this commit ever appeared here in this
branch. It looks like *I* committed it??? Must have been confused.

Closes NixOS#25572.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants