nixos/n8n: correct configuration, webhookUrl type #241783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised in NixOS#240189 I made some minor errors in the service definition.
github-actions
bot
added
6.topic: nixos
fabianhjr
approved these changes
Jul 5, 2023
fabianhjr
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
Janik-Haag
reviewed
Jul 6, 2023
|
@Janik-Haag How would you recommend testing for something like this? I've gone through a few of the existing test files but I'm unsure how to test that the environment variable is correctly set in the systemd unit. |
|
You can check if the string of |
|
Gave it my best shot :D Fairly straightforward |
Janik-Haag
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
(okay attempt 3. I'm really sorry for the confusion from the last PR that requested a review from everyone. I can't git at the moment apparently)
I realised in #240189 I made some minor errors in the service definition. The webhook URL configuration option wasn't properly passed through to the systemd configuration, and we can use the better
types.strtype overtypes.string.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)