Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup of credentials file overwrites the backup file itself if run again #144

Closed
niklaswesterstrahleknowit opened this issue Jul 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@niklaswesterstrahleknowit

Describe the bug
While starting to use the app for first time, it creates a backup of the credentials file that existed on users .aws directory (Mac client).

If at this point user restarts the application, while you have credentials file empty 0 bytes and no other login config. And restart the app, it notices the empty credentials file, and takes a new "backup" - overwriting the original backup.

Leapp Version
Mac 0.6.0

To Reproduce
Steps to reproduce the behavior:

  1. Install a fresh Leapp
  2. Open app, don't add credentials
  3. Quit app
  4. Open app again
  5. Check your homedir

-rw-r--r-- 1 0 Jul 6 12:53 credentials
-rw-r--r-- 1 f 0 Jul 6 12:38 credentials.leapp.bkp

Expected behavior
If credentials.leapp.bkp file exists, that file is not touched again, rather renamed with a random identifier.

Desktop (please complete the following information):

  • OS: MacOs
  • OS Version 11.4
  • Leapp Version 0.6.0
@niklaswesterstrahleknowit niklaswesterstrahleknowit added the bug Something isn't working label Jul 6, 2021
@andreacavagna01
Copy link
Contributor

We will fix this in the next release with this problem:
#133

thanks for reporting

@ericvilla
Copy link
Contributor

I've re-opened the #133 issue that will be closed upon next release

@andreacavagna01
Copy link
Contributor

fixed in v.0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants