Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leapp cli start session should show roles #341

Closed
lordgordon opened this issue Oct 4, 2022 · 4 comments · Fixed by #344
Closed

leapp cli start session should show roles #341

lordgordon opened this issue Oct 4, 2022 · 4 comments · Fixed by #344
Labels
enhancement New feature or request

Comments

@lordgordon
Copy link

lordgordon commented Oct 4, 2022

Is your feature request related to a problem? Please describe.
Using Leapp with AWS SSO, an user may have multiple roles per account. When running leap session start, the list only shows the accounts without the associated role:

> leap session start
? select a session (Use arrow keys)
❯ myorg-sec
  myorg-management
  myorg-prod
  myorg-qa
  myorg-qa
  myorg-prod
  myorg-prod
(Move up and down to reveal more choices)

This make impossible to choose the right session to start. A tedious workaround is to first run leapp session list -x, then leapp session start --sessionId <value copied from previous command>.

Describe the solution you'd like
When running leapp session start I would like to see a list like it already happens with macOS helper:

> leap session start
? select a session (Use arrow keys)
❯ myorg-sec / AdminRole
  myorg-management / AdminRole
  myorg-prod / AdminRole
  myorg-qa / AdminRole
  myorg-qa / ReadOnlyRole
  myorg-prod / ReadOnlyRole
  myorg-prod / SomeOtherSpecialRole

Describe alternatives you've considered
I don't have alternative proposals.

Additional context
Not applicable.

@lordgordon lordgordon added the enhancement New feature or request label Oct 4, 2022
@lordgordon
Copy link
Author

lordgordon commented Oct 4, 2022

Is this easy to implement? If so, I can submit a PR if you agree with this proposal.

@andreacavagna01
Copy link
Contributor

Yes. It is quite easy, it's just a modification of this line of code:

choices: availableSessions.map((session: any) => ({ name: session.sessionName, value: session })),

I will open the PR right now

@andreacavagna01
Copy link
Contributor

Created the PR @ericvilla need review to be merged,I'm adding you as a reviewer

@lordgordon
Copy link
Author

@andreacavagna01 thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants