While using SSO integrations in different regions starting a new session will fail with: "Session token not found or invalid"

[rusowyler]

Describe the bug
When you have 2 SSO integrations in different regions only sessions of the first integration you use will work. For the second integrations you will always get "Session token not found or invalid".

Leapp Version
Version 0.16.2 (0.16.2)

To Reproduce
Steps to reproduce the behavior:

1. Create 2 integrations in different regions
2. Start a session with the first one
3. Try to start a session with the second one.

Expected behavior
The session should start successfully.

Desktop (please complete the following information):

• OS: Mac Monterey
• OS Version 12.5.1
• Leapp Version 0.16.2 (0.16.2)

Additional context
The problem is in aws-sso-integration-service.ts line 196. When we check if the client exists we don't check if the region changed. If it had, we then use a client with the incorrect region leading to the failure.

Current code:

    setupSsoPortalClient(region) {
        if (!this.ssoPortal) {
            this.ssoPortal = new sso_1.default({ region });
            this.listAccountRolesCall = new throttle_service_1.ThrottleService((...params) => this.ssoPortal.listAccountRoles(...params).promise(), constants_1.constants.maxSsoTps);
        }
    }

Proposed fix:

    setupSsoPortalClient(region) {
        if (!this.ssoPortal || this.ssoPortal.config.region != region) {
            this.ssoPortal = new sso_1.default({ region });
            this.listAccountRolesCall = new throttle_service_1.ThrottleService((...params) => this.ssoPortal.listAccountRoles(...params).promise(), constants_1.constants.maxSsoTps);
        }
    }

Happy to make a PR if need it! Thanks for the incredible app!

[andreacavagna01]

Happy to make a PR if need it! Thanks for the incredible app!

Yes, please! Add the quick fix, and we will check it as soon as possible :)

[andreacavagna01]

Thanks for your contribution and the kind words!

[urz9999]

Will check this shortly and merge it to the codebase, sorry for the late response, and thanks again for the PR! 👍

[rusowyler]

Hi @urz9999! Any update on this? Do you need more info on my end?

Thanks again!

[ericvilla]

We've merged @rusowyler PR and included it in the last v0.17.0 release. The PR solves this issue.
Again, thank you for your contribution @rusowyler! It's very appreciated.