From 7e374d36ed5d82170cb288d0d376e0629715ea42 Mon Sep 17 00:00:00 2001 From: Michael Holt Date: Wed, 8 Sep 2021 07:52:52 -0700 Subject: [PATCH 1/2] feat: add tooltip to show session & detail info --- .../components/session/session-card/session-card.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/session/session-card/session-card.component.html b/src/app/components/session/session-card/session-card.component.html index d82f2a7b1..2cb3ff563 100644 --- a/src/app/components/session/session-card/session-card.component.html +++ b/src/app/components/session/session-card/session-card.component.html @@ -1,6 +1,6 @@
{{session.region}} -
+
{{session.sessionName}}{{ session | detail }}
From 303c9872d87a496fd476c3d60f0234c02ac987b5 Mon Sep 17 00:00:00 2001 From: Eric Villa Date: Fri, 10 Sep 2021 10:33:02 +0200 Subject: [PATCH 2/2] chore: moved '-' character outside of details --- src/app/components/session/session-card/detail.pipe.ts | 8 ++++---- .../session/session-card/session-card.component.html | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/components/session/session-card/detail.pipe.ts b/src/app/components/session/session-card/detail.pipe.ts index 8f2ae40e4..9c1c85d5d 100644 --- a/src/app/components/session/session-card/detail.pipe.ts +++ b/src/app/components/session/session-card/detail.pipe.ts @@ -14,15 +14,15 @@ export class DetailPipe implements PipeTransform { transform(session: Session): string { switch (session.type) { case(SessionType.awsIamRoleFederated): - return ' - ' + (session as AwsIamRoleFederatedSession).roleArn.split('role/')[1]; + return (session as AwsIamRoleFederatedSession).roleArn.split('role/')[1]; case(SessionType.azure): - return ' - ' + (session as AzureSession).subscriptionId; + return (session as AzureSession).subscriptionId; case(SessionType.awsIamUser): return ''; // (session as AwsIamUserSession).sessionName; case(SessionType.awsSsoRole): - return ' - ' + (session as AwsSsoRoleSession).roleArn.split('role/')[1]; + return (session as AwsSsoRoleSession).roleArn.split('role/')[1]; case(SessionType.awsIamRoleChained): - return ' - ' + (session as AwsIamRoleChainedSession).roleArn.split('role/')[1]; + return (session as AwsIamRoleChainedSession).roleArn.split('role/')[1]; } } } diff --git a/src/app/components/session/session-card/session-card.component.html b/src/app/components/session/session-card/session-card.component.html index 2cb3ff563..39d2e6bdf 100644 --- a/src/app/components/session/session-card/session-card.component.html +++ b/src/app/components/session/session-card/session-card.component.html @@ -1,7 +1,7 @@
{{session.region}}
- {{session.sessionName}}{{ session | detail }} + {{session.sessionName}} - {{ session | detail }}