Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/m1 support #242

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

nwouda
Copy link
Contributor

@nwouda nwouda commented Mar 24, 2022

Changelog

  • Added native support for Apple M1 devices
  • Bumped used NodeJS version to 16.14.1

Enhancements

  • Added native support for Apple M1 devices

@andreacavagna01
Copy link
Contributor

😍 will look at it tomorrow! Great job

@nwouda
Copy link
Contributor Author

nwouda commented Mar 25, 2022

There's also an option to build a universal release. Haven't tested it, but it should provide a single executable that is compatible with both architectures.

@andreacavagna01
Copy link
Contributor

have you tried to npm install? it breaks the code to me

@nwouda
Copy link
Contributor Author

nwouda commented Mar 25, 2022

Yes, I've successfully built it for local use. It only fails when trying to sign the release because it points to credentials I don't have on my system.

I'll do a clean build sometime soon to see if it still works. I could also try on a Windows and a Linux host to see if I get different results.

@nwouda
Copy link
Contributor Author

nwouda commented Mar 26, 2022

@andreacavagna01 Could you share what is breaking for you? I have also had issues, but those were related to dependency resolving.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/compiler
npm ERR!   @angular/compiler@"~13.2.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/compiler@"13.3.0" from @angular/[email protected]
npm ERR! node_modules/@angular/compiler-cli
npm ERR!   dev @angular/compiler-cli@"^13.2.1" from the root project
npm ERR!   peer @angular/compiler-cli@"^13.0.0 || ^13.3.0-rc.0" from @angular-devkit/[email protected]
npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev @angular-devkit/build-angular@"^13.2.2" from the root project

These happen both on the main branch as well as my branch. I decided to use --force to install anyway and that did not result in any other issues. Because it doesn't seem related to my change I didn't bother trying to fix it.

@andreacavagna01 andreacavagna01 merged commit 0950ca7 into Noovolari:master Mar 30, 2022
@andreacavagna01
Copy link
Contributor

just tested locally and it works! great job! from the next release it will be also the ARM version of macOS thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants