-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Copy Web Console URL action #306
Conversation
Would be awesome to open the browser from the CLI either. In general we're trying to keep the correspondence of actions between the gui and cli. |
Agree. I'll have a check on CLI also. |
Now that I got into it, it was easy to implement. But now it wonders if CLI command |
I think the two separate commands |
Great! I'll create documentation and tests for it and test it also in linux and mac tomorrow before pushing the CLI changes. |
Added CLI action and Jest-tests for it. |
Great work, Sami! 🥇 I think @ericvilla can review this next week, and we can integrate everything in the next release |
Thanks for the excellent pull request! After review, we decided to add an optional flag |
Glad to hear. It was 50/50 whether to use flag or create a new command and it is easy to change. |
Changelog
Added "Copy Web Console URL" action in session's copy-context menu.
Bugfixes
Enhancements
Closes #296.
Notes
Is this needed also in CLI?
No new tests as
openWebConsole - generates a valid aws url to log
covers it.Any comments, enhancements, proposals, fixes are very welcome.