Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers: Add hierarchy to the chooseFolder helper #556

Open
dwertheimer opened this issue Apr 11, 2024 · 0 comments
Open

Helpers: Add hierarchy to the chooseFolder helper #556

dwertheimer opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dwertheimer
Copy link
Collaborator

We now use the chooseFolder helper in a lot of places. But one thing I find frustrating is that I am often filtering for something, like the word project. It shows me lots of choices for that term, and some of them are indented, and visually seem to be indented under items above them, but they actually may not be in that folder at all. So I sometimes move a note to a folder that is not actually the one I wanted.

Screen Cap 2024-04-11 at 11 14 44@2x

In the above example, you would assume all these subfolders are inside the folder "Travel", but in fact, they are not!

On the other hand, something I really like about your getFolderListMinusExclusions() function is that it solves this issue by putting the whole path in the choice. So when you filter, you actually see the whole path to that folder on the line.

Screen Cap 2024-04-11 at 11 16 28@2x

I would like to suggest/recommend that we change chooseFolder to use the format/output of getFolderListMinusExclusions() rather than making its own folder list with just icons/indents.

I guess we could make it another parameter for format, but I think the getFolderListMinusExclusions() approach is better and I would recommend we just change the chooseFolder helper to use it instead so all plugins that use it just get better.

@dwertheimer dwertheimer added the enhancement New feature or request label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants