Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Microsoft.VisualStudio.ProjectSystem.Managed from PackageDownload to PackageReference #9620

Closed
drewnoakes opened this issue May 28, 2020 · 1 comment
Closed

Convert Microsoft.VisualStudio.ProjectSystem.Managed from PackageDownload to PackageReference #9620

drewnoakes opened this issue May 28, 2020 · 1 comment
Labels
Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Product:VS.Client Type:Engineering product/infrastructure work/not a customer bug/feature/DCR

Comments

@drewnoakes
Copy link

From https://github.com/NuGet/NuGet.Client/pull/3392/files#r428498657

Microsoft.VisualStudio.ProjectSystem uses PackageDownload to reference Microsoft.VisualStudio.ProjectSystem.Interop directly with EmbedInteropTypes set to true.

https://github.com/NuGet/NuGet.Client/blob/34ceb7d3d5a70ba4b1ecf196e5902dcc9ffed05d/test/NuGet.Clients.Tests/NuGet.PackageManagement.VisualStudio.Test/NuGet.PackageManagement.VisualStudio.Test.csproj#L62-L65

NuGet/NuGet.Client#3392 copied this pattern for the .NET Project System packages, however this isn't necessary for Microsoft.VisualStudio.ProjectSystem.Managed and Microsoft.VisualStudio.ProjectSystem.Managed.VS.

Converting these to PackageReference triggers a package downgrade error on Microsoft.CodeAnalysis.FxCopAnalyzers.

Upgrading Microsoft.CodeAnalysis.FxCopAnalyzers that to 3.0.0 triggers 90 new errors, many of which look like they're worth a proper review.
@drewnoakes drewnoakes mentioned this issue May 28, 2020
Merged
@nkolev92 nkolev92 added Type:Bug Product:VS.Client Type:Engineering product/infrastructure work/not a customer bug/feature/DCR Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. labels May 28, 2020
@nkolev92 nkolev92 removed the Type:Bug label Nov 3, 2022
@mitchcapper mitchcapper mentioned this issue Mar 29, 2024
Open
@nkolev92
Copy link
Member

NuGet/NuGet.Client@20be995 did it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Product:VS.Client Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drewnoakes @nkolev92 @heng-liu