This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Support labels for GitLab merge requests #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,5 +21,8 @@ public class MergeRequest | |||
|
|
|||
| [JsonProperty("remove_source_branch")] | |||
| public bool RemoveSourceBranch { get; set; } | |||
|
|
|||
| [JsonProperty("lables")] | |||
There was a problem hiding this comment.
I think this should be labels.
There was a problem hiding this comment.
Haha, damn, I was quite sure to copy it. Silly, thanks for taking a look, Max!
There was a problem hiding this comment.
No problem, that is why we do code reviews :)
There was a problem hiding this comment.
And that's fixed... 🤦♂
|
Small typo, but LGTM once fixed. |
|
Thanks Ivan! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Brings support for label to GitLab merge requests.
We don't support it.
🆕 What is the new behavior (if this is a feature change)?
We support it.
💥 Does this PR introduce a breaking change?
Nope.
🐛 Recommendations for testing
Try to create a gitlab MR.
📝 Links to relevant issues/docs
Already supported by the API. https://docs.gitlab.com/ee/api/merge_requests.html#create-mr
Just never bother to implement it.
🤔 Checklist before submitting