Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what TableComponent each char in a preset is mapped to #164

Open
tisonkun opened this issue Dec 28, 2024 · 2 comments
Open

Document what TableComponent each char in a preset is mapped to #164

tisonkun opened this issue Dec 28, 2024 · 2 comments

Comments

@tisonkun
Copy link
Contributor

I made a style:

const TABLE_STYLE_PRESET: &str = "||--+-++|    -+++++";

With several times attempt for understand what each char means.

Although we have current_style_as_preset as a helper, document what TableComponent each char in a preset is mapped to would make this magic string more understandable.

@Nukesor
Copy link
Owner

Nukesor commented Dec 28, 2024

Does the documentaton on load_preset help you?
https://docs.rs/comfy-table/latest/comfy_table/struct.Table.html#method.load_preset

Feel free to create an MR to link to those docs at the places you feel they should be linked from :)

@Nukesor
Copy link
Owner

Nukesor commented Jan 29, 2025

#168 and #167

Those need a few regression tests that fail on main first, before fixing them for good.
I would also like to get a proper understanding on how to fix them and whether other pieces might be affected as well :D
Correct UTF-8 handling really is tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants