Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Option: don't sell if min price reached #10

Open
omicron321 opened this issue Apr 18, 2017 · 4 comments
Open

Feature request : Option: don't sell if min price reached #10

omicron321 opened this issue Apr 18, 2017 · 4 comments

Comments

@omicron321
Copy link

Option: don't sell if min price reached and no recent sale (or no buy offers)

I'd rather not list cards that aren't going to sell anyway, like hundreds of cards for sale at 0.03 with no buyers.
Just to avoid cluttering market page and so I can recycle them, dust or do whatever.

@Nuklon
Copy link
Owner

Nuklon commented Apr 19, 2017

Do you want

  1. min price AND no recent sale
    or
  2. min price OR no recent sale?

I'd rather not add too many price options though, I think there are quite a lot of them already and the code for price calculation isn't very readable anymore.
I'll have to think about a nice way to add all these options.
Then there's also that the buy orders and sell orders in Steam's API aren't returning up-to-date values, only the minimum buy order price (and maximum sell order price) are.

@omicron321
Copy link
Author

omicron321 commented Apr 20, 2017

I think just forget about this feature request.
As you said, no need to clutter code here and functionnality/ergonomy may get impacted.

Maybe a relisting/delisting feature for items that aren't likely to be sold could do the job.
Something like on main market page : a button to delist all items with (no buy offers and 200+ sell offers at $0.03)

@Nuklon
Copy link
Owner

Nuklon commented Apr 20, 2017

I'll have to think about this for a while, ideally I'd like to change the price calculation in a way to make it more variable, but I'm not looking to add a lot of complicated code for it.

About delisting, that's one way to go but then you'd list all cards/items again at the inventory if you'd use the Sell All buttons, so that's not perfect either.

@pacopepepipo
Copy link

pacopepepipo commented Jan 7, 2019

I just came back to open the same request.

Instead of selling it at the minimum, just the option

if minimum price is less than X
then skip and not sell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants