"Merges the description in the normal object" is modifying the object on the page

[xPaw]

This:

Steam-Economy-Enhancer/code.user.js

Lines 2215 to 2216 in 8f90b99

	// Merges the description in the normal object, this is done to keep the layout consistent with the market page, which is also flattened.
	Object.assign(value, value.description);

I was writing some code for steamdb extension, and assumed the properties I saw on the item were present, but I should have been looking at item.description instead.

Is this merging actually needed?

[Nuklon]

On inventory page, m_rgAssets holds only basic info where the bulk of the data is inside description. On the market page, m_rgAssets contains everything directly and there the description is empty. It's likely possible to remove this merging entirely, but then all uses need to be checked as the properties are likely under description.

[xPaw]

I've noticed some code already does this, like so:

Steam-Economy-Enhancer/code.user.js

Lines 820 to 823 in c5b059b

	if (item.market_fee != null)
	publisherFee = item.market_fee;
	else if (item.description != null && item.description.market_fee != null)
	publisherFee = item.description.market_fee;

[Nuklon]

Yeah, I think it's possible to disable merging, but I think all usages need to be well checked, I think the inventory stuff is pretty easy to fix as it's mostly under the description.