Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relisting items from market: remove all items first, then request inventory #231

Open
xPaw opened this issue Sep 22, 2024 · 2 comments
Open

Comments

@xPaw
Copy link
Contributor

xPaw commented Sep 22, 2024

Currently for every item, it removes the item, and then gets the inventory after a random delay. This is inefficient. A way to fix this would be remove all the items first, then request the inventory once.

@Nuklon
Copy link
Owner

Nuklon commented Oct 4, 2024

This was previously done, but the ids were at some point no longer the same after delisting from market.

@xPaw
Copy link
Contributor Author

xPaw commented Oct 4, 2024

I thought the code looks for the same item by id in inventory, did I misread? Otherwise this would be unreliable and could end up listing a new item that wasn't removed from market?

EDIT: I see it's checking by hash name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants