Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] payment_redsys: remove website_sale dependency #3777

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[16.0][IMP] payment_redsys: remove website_sale dependency #3777

merged 1 commit into from
Oct 31, 2024

Conversation

IJOL
Copy link

@IJOL IJOL commented Oct 16, 2024 •
edited
Loading

@IJOL IJOL changed the title [UPD] delete website_sale dependency [16.0] - payment_redsys - remove website_sale dependency Oct 16, 2024
@pedrobaeza
Copy link
Member

Utiliza por favor un mensaje de commit adecuado: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@ValentinVinagre
Copy link
Contributor

Reference: #3751

@ValentinVinagre
Copy link
Contributor

@Jaimermaccione

@IJOL IJOL force-pushed the 16.0-payment_redsys-website-dep-deleted branch from 46ae393 to f8f4ea3 Compare October 16, 2024 14:23
Jaimermaccione
Jaimermaccione approved these changes Oct 21, 2024
View reviewed changes
Copy link

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Revisión funcional hecha en runboat.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 21, 2024
@pedrobaeza
Copy link
Member

Hola, @IJOL el mensaje de commit debe incluir el nombre del módulo. Echa un vistazo a https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

¿Puedes cambiarlo y fusionamos?

HaraldPanten
HaraldPanten approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcionalmente OK.

@HaraldPanten HaraldPanten changed the title [16.0] - payment_redsys - remove website_sale dependency [16.0][IMP] payment_redsys: remove website_sale dependency Oct 21, 2024
@HaraldPanten
Copy link
Contributor

@IJOL Como dice Pedro. Pon un mensaje de commit que siga las guidelines de OCA. Por ejemplo --> [IMP] payment_redsys: remove website_sale dependency.

Y con eso ya lo tiramos adelante. Gracias.

@HaraldPanten
Copy link
Contributor

@IJOL Pudiste echarle un vistazo a los comentarios de Pedro?

En caso de que no tengas disponibilidad, vamos a lanzar nosotros el PR.

Gracias.

@IJOL
[IMP] payment_redsys: remove website_sale dependency, and fix url gen…
f0b5d13 
…eration to make web.base.url the default if website is not installed
@IJOL IJOL force-pushed the 16.0-payment_redsys-website-dep-deleted branch from f8f4ea3 to f0b5d13 Compare October 29, 2024 14:08
@HaraldPanten
Copy link
Contributor

@pedrobaeza Si lo ves bien, lo tiramos adelante. El mensaje de commit ya tiene el formato/estructura adecuado.

@pedrobaeza
Copy link
Member

Sí, como no avisó, no sabía que lo había cambiado.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3777-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f53c52c into OCA:16.0 Oct 31, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 913c99d. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten
Copy link
Contributor

Nos encargamos de llevarlo a otras versiones. Gracias por la aportación y las revisiones 👍

This was referenced Nov 12, 2024
Merged
Draft
@IJOL IJOL deleted the 16.0-payment_redsys-website-dep-deleted branch November 13, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaimermaccione Jaimermaccione Jaimermaccione approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@IJOL @pedrobaeza @ValentinVinagre @HaraldPanten @OCA-git-bot @sergio-teruel @Jaimermaccione