Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocrd-olena-binarize silently ignores non-existent input file group #76

Closed
mikegerber opened this issue May 18, 2021 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@mikegerber
Copy link
Contributor

mikegerber commented May 18, 2021

For any workspace, a non-existent input file group is silently ignored, without an error:

% ocrd-olena-binarize -I DOES-NOT-EXIST -O OCR-D-IMG-BIN 
% 

Other processors report a much more useful error, e.g.:

Exception: Invalid input/output file grps:
        Input fileGrp[@USE='OCR-D-IMG-BIN'] not in METS!
@kba kba self-assigned this May 18, 2021
@kba kba added the bug Something isn't working label May 18, 2021
@mikegerber
Copy link
Contributor Author

#75 is somewhat related because it still creates the (empty) output directory.

@bertsky
Copy link
Collaborator

bertsky commented May 18, 2021

I believe bashlib's ocrd__parse_argv needs to do something along the lines of ocrd.decorators.ocrd_cli_wrap_processor here (which calls WorkspaceValidator.check_file_grp on the workspace and filegrps).

@mikegerber
Copy link
Contributor Author

A little reasoning why this important: We have a "workflow script" that runs binarization and then layout segmentation. Because the user used the wrong input file group, no binarization was generated and - confusingly - the layout segmentation failed.

@bertsky
Copy link
Collaborator

bertsky commented Nov 30, 2021

With the fix now available in core (and hopefully also ocrd_all) I'd say we can close. Let me know @mikegerber if the problem persists.

@bertsky bertsky closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants