Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.eodag: remove experimental tool warning #1245

Open
wants to merge 1 commit into
base: grass8
Choose a base branch
from

Conversation

veroandreo
Copy link
Contributor

I suggest removing the warning since the GSoC was completed successfully some months ago, EODAG released 3+ version that solved several issues we dealt with during the development of the tool and, last but not least, the warning clutters every text output in the terminal

@HamedElgizery what do you say?

@HamedElgizery
Copy link
Contributor

HamedElgizery commented Nov 18, 2024

I suggest removing the warning since the GSoC was completed successfully some months ago, EODAG released 3+ version that solved several issues we dealt with during the development of the tool and, last but not least, the warning clutters every text output in the terminal

Yes, I agree. EODAG 3 has solved most, if not all, of the issues that we faced.
I also think IMHO, that it would be helpful if we restrict the module to only use EODAG 3+, and throw a fatal error if the version is below 3.

if int(eodag.__version__.split(".")[0]) < 3:
    gs.fatal(
        _(
            "eodag 3.0.0 or higher is required. eodag {} was found.".format(
                eodag.__version__
            )
        )
    )

@@ -1323,13 +1323,6 @@ def main():


if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add this after the try except block to force the usage of EODAG 3:

if int(eodag.__version__.split(".")[0]) < 3:
    gs.fatal(
        _(
            "eodag 3.0.0 or higher is required. eodag {} was found.".format(
                eodag.__version__
            )
        )
    )

Not sure if there is a different format for these type of error messages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninsbl what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants