Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot-proactive-messaging-teamsfx does not need an AAD app #1311

Open
blackchoey opened this issue Jul 2, 2024 · 6 comments
Open

bot-proactive-messaging-teamsfx does not need an AAD app #1311

blackchoey opened this issue Jul 2, 2024 · 6 comments
Assignees

Comments

@blackchoey
Copy link
Collaborator

The https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-proactive-messaging-teamsfx sample seems not calling external APIs in the code. So it does not need an AAD app.
Below step in teamsapp.yml and teamsapp.local.yml could be removed to avoid creating an AAD app.
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-proactive-messaging-teamsfx/teamsapp.yml#L13-L25
Other AAD app related content like the AAD app manifest also needs to be removed.

Hi @blackchoey! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@Nivedipa-MSFT
Copy link
Collaborator

Nivedipa-MSFT commented Jul 3, 2024

@blackchoey - Thanks for reporting your issue. We are not quite clear on your issue, could you please provide more details on your issue?
As per our understanding in order to send proactive messages using bot, AAD app is required. right?

@Nivedipa-MSFT
Copy link
Collaborator

@blackchoey - Could you please provide more details on your issue to investigate further?

@blackchoey
Copy link
Collaborator Author

@Nivedipa-MSFT The sample does not need this step: https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-proactive-messaging-teamsfx/teamsapp.yml#L13-L25.
I'm suggesting to remove this step to avoid possible confusions. There's customer asking why this sample need to create that AAD app.

@Nivedipa-MSFT
Copy link
Collaborator

Nivedipa-MSFT commented Jul 11, 2024

@blackchoey - We have informed this to the sample team. PR will be raised to make necessary changes.

@Nivedipa-MSFT
Copy link
Collaborator

@blackchoey - PR has merged. Could you please check and let us know if you have any query here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants